Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added leakage verification #2051

Closed
wants to merge 1 commit into from
Closed

feat: added leakage verification #2051

wants to merge 1 commit into from

Conversation

alexandreliberato
Copy link
Contributor

@alexandreliberato alexandreliberato commented Aug 7, 2022 •
edited
Loading

To avoid defects and resource waste we can use uber's goleak to detect goroutine leakages.

Added

  • uber-go/goleak library
  • main_test files to test leakage in all test package tests (eskipfile, filters/serve and dataclients/kubernets)

Related to #1989

@alexandreliberato
Copy link
Contributor Author

Related to #2051

@szuecs szuecs marked this pull request as ready for review August 8, 2022 19:27
@szuecs
Copy link
Member

szuecs commented Aug 8, 2022

Please do rebase with signoff to fix DCO, thanks!

@szuecs
Copy link
Member

szuecs commented Aug 23, 2022

@alexandreliberato can you please pull and rebase your commit on the current master?
It will fix the test errors, that blocks the PR from merging.
And then you need to run git amend --signoff before push -f and have the DCO also fixed.

@szuecs szuecs mentioned this pull request Nov 3, 2022
Merged
@szuecs
Copy link
Member

szuecs commented Nov 8, 2022

#2128

@szuecs szuecs closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandreliberato @szuecs