webhook: validate skipper annotations in ingress #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaSaber
commented
Aug 3, 2023
szuecs
reviewed
Aug 7, 2023
szuecs
reviewed
Aug 7, 2023
szuecs
reviewed
Aug 7, 2023
szuecs
reviewed
Aug 7, 2023
szuecs
reviewed
Aug 7, 2023
cmd/webhook/admission/testdata/ingress/invalid-filters-and-predicates.json
Outdated
Show resolved
Hide resolved
szuecs
reviewed
Aug 7, 2023
szuecs
reviewed
Aug 7, 2023
cmd/webhook/admission/testdata/ingress/valid-ingress-with-annotations.json
Outdated
Show resolved
Hide resolved
szuecs
reviewed
Aug 7, 2023
szuecs
reviewed
Aug 7, 2023
szuecs
reviewed
Aug 7, 2023
szuecs
reviewed
Aug 7, 2023
szuecs
reviewed
Aug 7, 2023
MustafaSaber
force-pushed
the
validate-skipper-annotations-in-ingress
branch
from
f5698b8
to
ecf9af6
Compare
MustafaSaber
commented
Aug 9, 2023
| @@ -0,0 +1,50 @@ | |||
| package admission | |||
There was a problem hiding this comment.
Lets name the file ingress.go as it is in the admission folder.
There was a problem hiding this comment.
I wonder if we should rename admission to validation, because we do not plan to change documents but to validate them.
In Kubernetes docs this is not really great documented, but there are both and there are (or were?) both registered as admission webhook AFAIK.
There was a problem hiding this comment.
There are exported symbols. If we rename I propose we unexport everything to allow active development.
There was a problem hiding this comment.
Maybe we wait to see in the next steps, it make sense because we may move this package to another place for filter registry, maybe we can rename with the movement?
cmd/webhook/admission/testdata/ingress/valid-ingress-with-annotations.json
Outdated
Show resolved
Hide resolved
cmd/webhook/admission/testdata/ingress/valid-ingress-with-annotations.json
Outdated
Show resolved
Hide resolved
MustafaSaber
force-pushed
the
validate-skipper-annotations-in-ingress
branch
from
fdc381e
to
42afc18
Compare
MustafaSaber
commented
Aug 9, 2023
MustafaSaber
commented
Aug 9, 2023
MustafaSaber
force-pushed
the
validate-skipper-annotations-in-ingress
branch
2 times, most recently
from
4e0ac28
to
9e8c82a
Compare
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
address comments Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
…ded for backward comptiability Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Add validatior to admitter Export skipper ingress annotations Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Clean admitter functions Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
This reverts commit 0cd73f2. Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
force-pushed
the
validate-skipper-annotations-in-ingress
branch
from
9e8c82a
to
53f054d
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should introduce the custom
ValidationWebhookfor skipper ingress annotations (e.gzalando.org/skipper-routes,zalando.org/skipper-filterandzalando.org/skipper-predicate), currently we skip the annotation if something is wrong from skipper side at https://github.com/zalando/skipper/blob/master/dataclients/kubernetes/ingress.go#L227-L271This is also a followup to #1618 & #2478