fix clusterRatelimit with more than one ratelimit instance #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryszka
reviewed
Jan 16, 2019
aryszka
approved these changes
Jan 16, 2019
|
👍 |
|
as we discussed the PR in its current form doesn't fully fix the problem |
|
👎 |
|
After an internal discussion we agreed on having the implementation changed to #912 (comment) which enables full control of grouping ratelimiters across routes. |
szuecs
force-pushed
the
fix/clusterRatelimit-multi-instances
branch
2 times, most recently
from
3e41f4f
to
b72a1c1
Compare
|
@aryszka the code was changed as discussed with internal customers and based on your comment #912 (comment). If the code is good in the review and tested successfully in a dev cluster, I would fix all docs according to the implementation. |
szuecs
force-pushed
the
fix/clusterRatelimit-multi-instances
branch
2 times, most recently
from
3f61594
to
00df64f
Compare
aryszka
reviewed
Jan 25, 2019
proxy/proxy.go
Outdated
|
|
||
| if rl.Allow(s) { | ||
| return settings, 0 | ||
| allow = allow && rl.Allow(s) |
There was a problem hiding this comment.
i think the allow var is not required. It could be just:
if !rl.Allow(s) {
return setting, rl.RetryAfter(s)
}
|
lgtm please update the branch once #932 gets merged |
feature: cluster ratelimit instances can now grouped fix: cluster ratelimit instances do not override shared data anymore, based on the group the ratelimit data is stored in the swarm fix: X-Forwarded-For Header Lookuper in cluster ratelimits is now treated similar to the default refactor: rename file to make it more expressive refactor: rename lb group eskip file test: change test setup to have 2 different ratelimit groups Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
szuecs
force-pushed
the
fix/clusterRatelimit-multi-instances
branch
from
dd5cdd9
to
c2023f5
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #903 clusterRatelimit with more than one ratelimit instance, which overwrote the shared data from other ratelimit instances.
Signed-off-by: Sandor Szücs sandor.szuecs@zalando.de