Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zally CLI lint command omits success message #716

Closed
roxspring opened this issue May 24, 2018 · 0 comments
Closed

Zally CLI lint command omits success message #716

roxspring opened this issue May 24, 2018 · 0 comments

Comments

@roxspring
Copy link
Collaborator

In #652 we agreed on a formatted message "Congratulations! No violations found." in the case of no violations but this didn't get implemented.
roxspring added a commit to roxspring/zally that referenced this issue May 24, 2018
@roxspring
zalando#716 added success message when no violations found
628fb47
roxspring added a commit to roxspring/zally that referenced this issue May 26, 2018
@roxspring
Added success message when no violations found zalando#716
f77a039
maxim-tschumak added a commit to roxspring/zally that referenced this issue Jun 4, 2018
@maxim-tschumak
Merge branch 'master' into feature/zalandogh-716-cli-success-message
7b868c2
maxim-tschumak added a commit that referenced this issue Jun 4, 2018
@maxim-tschumak
Merge pull request #717 from roxspring/feature/gh-716-cli-success-mes…
98e5d17 
…sage

Added success message when no violations found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roxspring