Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of required path parameters #1252

Merged
merged 4 commits into from
Jun 22, 2021

Conversation

vadeg
Copy link
Contributor

@vadeg vadeg commented Jun 7, 2021

Add path parameter validation

Determines whether this parameter is mandatory. If the parameter location is "path", this property is REQUIRED and its value MUST be true. Otherwise, the property MAY be included and its default value is false.

Fixes #459

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #1252 (e575f34) into master (34594a2) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1252      +/-   ##
============================================
- Coverage     76.10%   76.09%   -0.02%     
- Complexity      966      973       +7     
============================================
  Files           186      187       +1     
  Lines          2871     2878       +7     
  Branches        501      502       +1     
============================================
+ Hits           2185     2190       +5     
- Misses          426      427       +1     
- Partials        260      261       +1     
Impacted Files Coverage Δ
.../kotlin/org/zalando/zally/core/util/OpenApiUtil.kt 51.19% <0.00%> (-0.62%) ⬇️
...g/zalando/zally/ruleset/zally/PathParameterRule.kt 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34594a2...e575f34. Read the comment docs.

@vadeg
Copy link
Contributor Author

vadeg commented Jun 8, 2021

👍

Copy link
Member

@tkrop tkrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would let us cover all use cases with tests.

@vadeg
Copy link
Contributor Author

vadeg commented Jun 20, 2021

Waits #1258 to be merged.

@tkrop
Copy link
Member

tkrop commented Jun 22, 2021

👍

1 similar comment
@vadeg
Copy link
Contributor Author

vadeg commented Jun 22, 2021

👍

@vadeg vadeg merged commit 750a31c into master Jun 22, 2021
@tkrop tkrop deleted the gh-459-validate-path-parameters branch June 22, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rules proposition
3 participants