-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation of required path parameters #1252
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
============================================
- Coverage 76.10% 76.09% -0.02%
- Complexity 966 973 +7
============================================
Files 186 187 +1
Lines 2871 2878 +7
Branches 501 502 +1
============================================
+ Hits 2185 2190 +5
- Misses 426 427 +1
- Partials 260 261 +1
Continue to review full report at Codecov.
|
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I would let us cover all use cases with tests.
...zally-ruleset-zally/src/test/kotlin/org/zalando/zally/ruleset/zally/PathParameterRuleTest.kt
Show resolved
Hide resolved
Waits #1258 to be merged. |
👍 |
1 similar comment
👍 |
Add path parameter validation
Fixes #459