714 query parameter collection format rule migration #805
Conversation
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
============================================
- Coverage 84.61% 84.37% -0.24%
+ Complexity 994 992 -2
============================================
Files 172 171 -1
Lines 2743 2740 -3
Branches 420 421 +1
============================================
- Hits 2321 2312 -9
- Misses 213 215 +2
- Partials 209 213 +4
Continue to review full report at Codecov.
|
| .filter { "query" == it.value.`in` && "array" == it.value.schema.type } | ||
| .filter { it.value.style == null || allowedStyle != it.value.style } | ||
| .map { context.violation(description, it.value) } | ||
| else emptyList() |
There was a problem hiding this comment.
I would here either use .values (since the key is not needed) or use deconstruction { (_, value) -> ...}. Both ways would avoid the .value call.
| * Returns all defined schemas of an API specification | ||
| * @return a collection of schemas | ||
| */ | ||
| fun OpenAPI.getAllSchemas(): Collection<Schema<Any>> = this.components.schemas.orEmpty().values + |
There was a problem hiding this comment.
@maxim-tschumak :
What happened to the long exhaustive version of that that I did some weeks ago...? Did we discarded it?
There was a problem hiding this comment.
Hm... I don't know. This is the function I've implemented last week and now I've just moved it to the right class (as you proposed).
|
👍 |
|
👍 |
maxim-tschumak
deleted the
714-query-parameter-collection-format-rule-migration
branch
Related to #714.
Related to the Guideline change proposed in zalando/restful-api-guidelines#440