Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SuccessResponseAsJsonObject rule to use context object to support OpenAPI 3 #807

Merged
merged 1 commit into from Aug 22, 2018

Conversation

maxim-tschumak
Copy link
Contributor

Related to #714

@codecov-io
Copy link

codecov-io commented Aug 22, 2018

Codecov Report

Merging #807 into master will decrease coverage by 0.02%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #807      +/-   ##
============================================
- Coverage     84.37%   84.35%   -0.03%     
+ Complexity      992      988       -4     
============================================
  Files           171      171              
  Lines          2740     2736       -4     
  Branches        421      416       -5     
============================================
- Hits           2312     2308       -4     
  Misses          215      215              
  Partials        213      213
Impacted Files Coverage Δ Complexity Δ
...ly/rule/zalando/SuccessResponseAsJsonObjectRule.kt 69.23% <63.63%> (-7.24%) 15 <13> (-4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b1890...78a9bd3. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost
Copy link

ghost commented Aug 22, 2018

👍

1 similar comment
@maxim-tschumak
Copy link
Contributor Author

👍

@maxim-tschumak maxim-tschumak merged commit 79d3293 into master Aug 22, 2018
@maxim-tschumak maxim-tschumak deleted the 714-success-response-as-json-object branch August 22, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants