Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): migrate extensible enum rule to context object to support openapi 3 #810

Merged
merged 1 commit into from Aug 22, 2018

Conversation

maxim-tschumak
Copy link
Contributor

Related to #714

@maxim-tschumak maxim-tschumak force-pushed the 714-migrate-extensible-enum-rule branch from ae81305 to 2d11016 Compare August 22, 2018 14:54
@codecov-io
Copy link

codecov-io commented Aug 22, 2018

Codecov Report

Merging #810 into master will increase coverage by 0.29%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #810      +/-   ##
============================================
+ Coverage     84.35%   84.65%   +0.29%     
+ Complexity      957      928      -29     
============================================
  Files           171      171              
  Lines          2647     2627      -20     
  Branches        407      397      -10     
============================================
- Hits           2233     2224       -9     
  Misses          198      198              
+ Partials        216      205      -11
Impacted Files Coverage Δ Complexity Δ
...src/main/java/de/zalando/zally/util/OpenApiUtil.kt 59.57% <100%> (+10.92%) 0 <0> (ø) ⬇️
...e/zalando/zally/rule/zalando/ExtensibleEnumRule.kt 80% <75%> (+14.28%) 6 <5> (-29) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71bdd29...2d11016. Read the comment docs.

@tkrop
Copy link
Member

tkrop commented Aug 22, 2018

👍

@maxim-tschumak
Copy link
Contributor Author

👍

@maxim-tschumak maxim-tschumak merged commit e5055cc into master Aug 22, 2018
@maxim-tschumak maxim-tschumak deleted the 714-migrate-extensible-enum-rule branch August 22, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants