Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): migrate snake_case in prop names rule to context object to support openapi 3 #815

Merged
merged 1 commit into from Aug 24, 2018

Conversation

maxim-tschumak
Copy link
Contributor

Related to #714

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #815 into master will decrease coverage by 0.19%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #815     +/-   ##
===========================================
- Coverage      84.7%   84.51%   -0.2%     
+ Complexity      928      923      -5     
===========================================
  Files           171      171             
  Lines          2622     2628      +6     
  Branches        395      399      +4     
===========================================
  Hits           2221     2221             
- Misses          198      199      +1     
- Partials        203      208      +5
Impacted Files Coverage Δ Complexity Δ
...src/main/java/de/zalando/zally/util/OpenApiUtil.kt 58.62% <54.54%> (-0.96%) 0 <0> (ø)
...ando/zally/rule/zalando/SnakeCaseInPropNameRule.kt 83.33% <75%> (-16.67%) 6 <5> (-5)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc39c16...851ca96. Read the comment docs.

@tkrop
Copy link
Member

tkrop commented Aug 24, 2018

👍

1 similar comment
@maxim-tschumak
Copy link
Contributor Author

👍

@maxim-tschumak maxim-tschumak merged commit 83737f1 into master Aug 24, 2018
@maxim-tschumak maxim-tschumak deleted the 714-migrate-snake-case-in-prop-names-rule branch August 24, 2018 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants