feat(server): migrate snake_case query parameters rule to context object to support openapi 3 #816
Conversation
…ect to support openapi 3 (#714)
| } | ||
| fun checkQueryParameter(context: Context): List<Violation> = | ||
| context.api.getAllParameters().values | ||
| .filter { "query" == it.`in` } |
There was a problem hiding this comment.
Oh, I like it. This reminds me about old C rules :)
| /article: | ||
| get: | ||
| parameters: | ||
| - name: filterExpensiveArticles |
There was a problem hiding this comment.
How about checking lower letter strings with dashs and other no-alphabet charaters too?
There was a problem hiding this comment.
Okay, may be this is checked somewhere else.
There was a problem hiding this comment.
Yes, it should be a part of the utility class unit tests.
|
👍 |
|
@tkrop please re-approve (I've merged master into the branch) |
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
=========================================
Coverage ? 84.56%
Complexity ? 916
=========================================
Files ? 171
Lines ? 2624
Branches ? 397
=========================================
Hits ? 2219
Misses ? 197
Partials ? 208
Continue to review full report at Codecov.
|
|
👍 |
1 similar comment
|
👍 |
Related to #714