Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): migrate limit number of subresources rule to context object to support openapi 3 #821

Merged

Conversation

maxim-tschumak
Copy link
Contributor

Related to #714

@codecov-io
Copy link

codecov-io commented Aug 24, 2018

Codecov Report

Merging #821 into master will decrease coverage by 0.03%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #821      +/-   ##
============================================
- Coverage     85.45%   85.41%   -0.04%     
  Complexity      903      903              
============================================
  Files           170      170              
  Lines          2544     2544              
  Branches        389      389              
============================================
- Hits           2174     2173       -1     
  Misses          152      152              
- Partials        218      219       +1
Impacted Files Coverage Δ Complexity Δ
...ly/rule/zalando/SuccessResponseAsJsonObjectRule.kt 53.84% <0%> (-7.7%) 15 <13> (ø)
...ally/rule/zalando/LimitNumberOfSubResourcesRule.kt 85.71% <85.71%> (ø) 12 <12> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a153a5...f966635. Read the comment docs.

@tkrop
Copy link
Member

tkrop commented Aug 27, 2018

👍

@tkrop
Copy link
Member

tkrop commented Sep 5, 2018

👍

1 similar comment
@maxim-tschumak
Copy link
Contributor Author

👍

@maxim-tschumak maxim-tschumak merged commit 61623cf into master Sep 5, 2018
@maxim-tschumak maxim-tschumak deleted the 714-migrate-limit-number-of-sub-resources-rule branch September 5, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants