feat(server): migrate nested paths may be root paths rule to use context object to support OpenAPI 3 #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext object to support OpenAPI 3 (#714)
25 tasks
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
============================================
+ Coverage 84.91% 84.95% +0.03%
- Complexity 902 904 +2
============================================
Files 171 171
Lines 2553 2553
Branches 392 392
============================================
+ Hits 2168 2169 +1
Misses 151 151
+ Partials 234 233 -1
Continue to review full report at Codecov.
|
tkrop
reviewed
Sep 10, 2018
| val spec = """ | ||
| openapi: 3.0.1 | ||
| paths: | ||
| pets/: {} |
There was a problem hiding this comment.
Missing check for /pets/dogs. This is a legal pattern and should be interpreted as top level resource.
| val spec = """ | ||
| openapi: 3.0.1 | ||
| paths: | ||
| "/countries/{country-id}/cities/{city-id}": {} |
There was a problem hiding this comment.
We should also check for something like /countries/{country-id}/populated/cities/{city-id}.
|
@tkrop @ddufourboivin-zalando please have another look |
|
👍 |
ghost
approved these changes
Sep 10, 2018
|
👍 |
maxim-tschumak
deleted the
714-migrate-nested-paths-may-be-root-paths-rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #714