Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixing #8] External PostgreSQL Database support #47

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

mwallschlaeger
Copy link
Contributor

Description

This PR allows to configure an external PostgreSQL database server to be used in geonode-k8s.

Related to: GeoNode/geonode#11340

Type of Change

Please select the relevant option:

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe)

Related Issue

If there is an existing issue related to this pull request, please reference it here.

closes #8

Checklist

Please ensure that your pull request meets the following requirements:

  • The pull request is limited to one type (docs, feature, bug fix, etc.)
  • The pull request is as small as possible. Consider opening multiple pull requests instead of one large one.
  • The feature or bug fix has been discussed and documented in an issue beforehand.

Additional Notes

Any additional information or context regarding the pull request can be provided here.

Thank you for creating this pull request

@mwallschlaeger mwallschlaeger added the feature new required feature label Aug 7, 2023
@mwallschlaeger mwallschlaeger self-assigned this Aug 7, 2023
ridoo
ridoo previously approved these changes Aug 7, 2023
Copy link
Contributor

@ridoo ridoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok on a skimmed review. I did not test it with an external database yet.

db_user = database = os.getenv('GEONODE_GEODATABASE')
db_password = os.getenv('GEONODE_GEODATABASE_PASSWORD')
db_host = os.getenv('DATABASE_HOST')
db_port = os.getenv('DATABASE_HOST')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DATABASE_PORT

@mwallschlaeger mwallschlaeger merged commit bde327c into main Aug 8, 2023
1 check passed
@mwallschlaeger mwallschlaeger deleted the issue#8_external_postgresq_database_support branch September 6, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new required feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External Postgresql Database Support
2 participants