Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mods: Add support for lock-sprint and hold-crouch #2

Closed
zalgonoise opened this issue Jul 23, 2023 · 1 comment · Fixed by #4
Closed

mods: Add support for lock-sprint and hold-crouch #2

zalgonoise opened this issue Jul 23, 2023 · 1 comment · Fixed by #4
Assignees
@zalgonoise
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@zalgonoise
Copy link
Owner

zalgonoise commented Jul 23, 2023 •
edited
Loading

This is a placeholder issue to add a feature introducing an input modifier, that allows sprint lock (not having to hold the key to run) and crouch toggle on key release, making crouch a press-and-hold action.

Config file: \APB Reloaded\APBGame\Config\DefaultInput.ini

Lock sprint diff:

< +Bindings=(Name="Sprint",Command="InputSprinting | OnRelease InputStopSprinting")
> +Bindings=(Name="Sprint",Command="InputstopSprinting | OnRelease InputSprinting")

Hold crouch diff:

< +Bindings=(Name="Duck",Command="Button m_bDuckButton | InputToggleDuck")
> +Bindings=(Name="Duck",Command="Button m_bDuckButton | InputToggleDuck | OnRelease InputToggleDuck")

Implementation notes:

  • It can still leverage the KeyValueModifier type if the key is set as +Bindings=(Name="Sprint" and +Bindings=(Name="Duck". Can be refactored to be its own BindingsModifier type in the future.

This feature must:

  • add a modifier for changing these settings individually
  • support to rollback configuration to its original settings
  • avoid making any changes by default (must be set by the caller, as a flag or environment variable)
  • add command-line flags for -lock-sprint and -hold-crouch
@zalgonoise zalgonoise added enhancement New feature or request good first issue Good for newcomers labels Jul 23, 2023
@zalgonoise zalgonoise self-assigned this Jul 23, 2023
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor/modifiers/key_value: remove getValue call from logMatch…
8e1fa80 
… call
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor/modifiers/sprint: add logic for sprint lock modifier
f26f47e
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor/modifiers/crouch: add logic for crouch lock modifier
d7be0a1
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor/modifiers/testing: added sprint and crouch tests; refac…
fce5558 
…tored test function
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor/modifiers/internal/testdata: refactored testdata FS str…
63e2bef 
…ucture
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: config: add InputConfig logic and command-line flags support
a9c1a9f
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor: updated processor logic to add modifiers on non-nil In…
461d410 
…putConfig; added tests
@zalgonoise zalgonoise mentioned this issue Jul 23, 2023
Merged
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor/modifiers/key_value: remove getValue call from logMatch…
a314fae 
… call
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor/modifiers/sprint: add logic for sprint lock modifier
b88ba4b
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor/modifiers/crouch: add logic for crouch lock modifier
3d173c5
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor/modifiers/testing: added sprint and crouch tests; refac…
78bdc4b 
…tored test function
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor/modifiers/internal/testdata: refactored testdata FS str…
a1d4e3f 
…ucture
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: config: add InputConfig logic and command-line flags support
bcd0ba4
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: processor: updated processor logic to add modifiers on non-nil In…
58e069b 
…putConfig; added tests
@zalgonoise
Copy link
Owner Author

Re-opening to update the README with this modifier

@zalgonoise zalgonoise reopened this Jul 23, 2023
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: README: update new modifiers' reference documentation
726c4d4
@zalgonoise zalgonoise mentioned this issue Jul 23, 2023
Merged
zalgonoise added a commit that referenced this issue Jul 23, 2023
@zalgonoise
#2: README: update new modifiers' reference documentation
273db17
@zalgonoise zalgonoise mentioned this issue Jul 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zalgonoise zalgonoise

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2: README: update new modifiers' reference documentation zalgonoise/apbrc
1 participant
@zalgonoise