Skip to content

Commit

Permalink
Fix actionsBlacklist/Whitelist to be also string as per documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
zalmoxisus committed Nov 26, 2018
1 parent 4bd69c8 commit 7252477
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/app/api/filters.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ export const FilterState = {
export function getLocalFilter(config) {
if (config.actionsBlacklist || config.actionsWhitelist) {
return {
whitelist: config.actionsWhitelist && config.actionsWhitelist.join('|'),
blacklist: config.actionsBlacklist && config.actionsBlacklist.join('|')
whitelist: typeof config.actionsWhitelist === 'object' ? config.actionsWhitelist.join('|') : config.actionsWhitelist,

This comment has been minimized.

Copy link
@JeremyJonas

JeremyJonas Nov 29, 2018

Getting Uncaught TypeError: Cannot read property 'join' of null after this change with actionsWhitelist = null or actionBlacklist = null

typeof null === 'object' evals to true - https://runkit.com/jeremyjonas/5c00276598e5d60014ec22df

This comment has been minimized.

Copy link
@zalmoxisus

zalmoxisus Nov 29, 2018

Author Owner

Good catch, should use Array.isArray instead. Thanks!

blacklist: typeof config.actionsBlacklist === 'object' ? config.actionsBlacklist.join('|') : config.actionsBlacklist
};
}
return undefined;
Expand Down

0 comments on commit 7252477

Please sign in to comment.