Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for width/height #17

Closed
quicksnap opened this issue Nov 19, 2015 · 7 comments
Closed

Option for width/height #17

quicksnap opened this issue Nov 19, 2015 · 7 comments
Milestone

Comments

@quicksnap
Copy link

I'd love to make the devtools popup larger. Will Chrome allow for that? I haven't worked in extension-land in a while.

If you can provide some pointers, I could maybe get some time for a PR.

Thanks!

@zalmoxisus
Copy link
Owner

Hey, @quicksnap.

Yes, it's just css, set here.

Why only the popup? The popup has 300px width, and the window 320px.

@quicksnap
Copy link
Author

Annnd now I see that you can open it as a window. And resize it.

Perhaps I should alter my PR to provide a link to open it as a window in the popup =)

@quicksnap
Copy link
Author

Also, this kicks ass.

@zalmoxisus
Copy link
Owner

Yes, a maximize button in the popup would be amazing. I planned it, but ended just with adding the instruction in the README, as I'm not so good in design.

With today's release, it would be easy to implement. To open the window we may just call window.devToolsExtension.open().

zalmoxisus added a commit that referenced this issue Nov 24, 2015
@zalmoxisus
Copy link
Owner

Hey, @quicksnap. I've extended popup width to 350px in 0.4.3. It should be enough the most of cases. Since the window is resizable, I figure we do not need it configurable.

I will add an 'expand' button to the action page (popup) in 0.5.0. Till then, I'll keep this issue open.

@zalmoxisus zalmoxisus added this to the v0.5.0 milestone Nov 24, 2015
@quicksnap
Copy link
Author

Cool! Yeah, I'm satisfied with it as-is for now, just knowing I can detach the window. More options are always cool, too =)

@zalmoxisus
Copy link
Owner

Implemented in v1.0.0-beta1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants