Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White popup. Add example? #4

Closed
peteruithoven opened this issue Oct 28, 2015 · 7 comments
Closed

White popup. Add example? #4

peteruithoven opened this issue Oct 28, 2015 · 7 comments

Comments

@peteruithoven
Copy link
Contributor

I've followed the instructions from the readme, but when I visit my project and open the extension it shows a white popup. Probably a javascript error. But I've never made a Chrome extension and I don't know how to debug it.
It would be great if there was a live example (todo?) website that I could visit to check if it was something in my project (not using window.devToolsExtension correctly).

@peteruithoven
Copy link
Contributor Author

Following the instructions from #2 (comment) I build the dev folder and loaded that as extension and suddenly the location of the exention icon changes and it does show the debugger.
Extension from: build/extension:
screen shot 2015-10-28 at 10 44 52
Extension from dev:
screen shot 2015-10-28 at 10 45 27

This is while trying this on the same project.

@zalmoxisus
Copy link
Owner

Yes, in ./build/extension we have the previous released version, while after npm start you get the upcoming version, which will be released today ;)
I will add ./buld to the .gitignore to avoid the confusions.
The main differences are described in #1.

I guess v0.0.1 didn't work because you loaded the page before loading the extension, just refresh the tab and it will work. Anyway, the new implementation should avoid such issues by hiding/showing pageAction's icon.

So, the upcoming release from dev works well?

@peteruithoven
Copy link
Contributor Author

Ah, thanks that clarifies that, sounds like a great improvement.

But the new (dev) version doesn't fully work I'm getting the following error in my console:

Uncaught DataCloneError: Failed to execute 'postMessage' on 'Window': An object could not be cloned.
  onChange @ page.bundle.js:30356
  (anonymous function) @ createStore.js:52
  dispatch @ createStore.js:50
  dispatch @ page.bundle.js:12277
  (anonymous function) @ bindActionCreators.js:12
  mouseMove @ group.js:374
  handleEvent @ group.js:104

The debugger only shows the @@init action.
Using Redux version 3.0.4. Are there other versions relevant?

(Again it would help to check this with a page that the debugger does work with)

@zalmoxisus
Copy link
Owner

We have the same issue in #5, but I cannot reproduce it. I just released 0.1.0. Could you please sync the git and try again with ./build/extension?

@zalmoxisus
Copy link
Owner

To test it, you may just use counter or mvc example from ./examples, just do npm i and npm start there. It should run on port 4001 and 4002.

@peteruithoven
Copy link
Contributor Author

I'll check with that example. I'll report issues relating to that postMessage in #5.
If you think it's a good idea this issue could serve as a todo to make a example website.

@zalmoxisus
Copy link
Owner

Yes. That would be really useful, especially when we'll have the extension in Chrome WebStore.

zalmoxisus added a commit that referenced this issue Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants