Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo #412

Open
jhen0409 opened this issue Oct 8, 2017 · 6 comments
Open

Monorepo #412

jhen0409 opened this issue Oct 8, 2017 · 6 comments

Comments

@jhen0409
Copy link
Collaborator

jhen0409 commented Oct 8, 2017

I think we could maintaining packages like remotedev-app, remotedev-utils, devui and the helper package in monorepo, use Yarn workspaces or Lerna.

@zalmoxisus what do you think about this?

@zalmoxisus
Copy link
Owner

I was thinking about this long time ago. But we either keep everything (including redux-devtools, react-native-debugger, remotedev-server and probably monitors as well) in a monorepo or not. I think mostly contributors would want to change something in monitors then see it in the extension or react-native-debugger, which is a rather difficult process now.

@jhen0409
Copy link
Collaborator Author

jhen0409 commented Nov 9, 2017

Since some monitors are no positive maintaining, that would be great if we could move the monitors here.

For react-native-debugger, I think it may not easy to move here because most issues are not related to Redux DevTools, and we have to use Releases for auto update. I might move the implementation here and make a test app.

@zalmoxisus
Copy link
Owner

Agree, it would make it much easier to contribute. Would you like to implement it here? Then I'll move all the parts.

@jhen0409
Copy link
Collaborator Author

Yes, I'll implement it in a few days. :)

@zalmoxisus
Copy link
Owner

zalmoxisus commented Nov 26, 2017

Thanks! :)
I'll publish a new patch this days to fix some issues. Then we can start moving everything.

@zalmoxisus
Copy link
Owner

If anyone interested in this issue, please refer also to reduxjs/redux-devtools#412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants