Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError. Cannot read property 'split' of undefined #49

Closed
dahei opened this issue Feb 4, 2016 · 6 comments
Closed

Uncaught TypeError. Cannot read property 'split' of undefined #49

dahei opened this issue Feb 4, 2016 · 6 comments

Comments

@dahei
Copy link

dahei commented Feb 4, 2016

When using the extension I get sometimes (not always) an error while initializing my redux/react app.

When disabling the redux-devtools-extension the error does not appear, so it seems to be related.

image

As you can see, the exception is thrown in the isAllowed() function, which is part of the extension.

So my guess, is that here the localOptions.urls are not yet initialized.

@zalmoxisus
Copy link
Owner

Do you use the default configuration or changed something in settings (on the option page)?

@dahei
Copy link
Author

dahei commented Feb 4, 2016

I would say, I use it "out of the box". Here are my settings (have to split it in 2 shots):

image

image

@zalmoxisus
Copy link
Owner

Wasn't able to reproduce, but yes, if chrome.storage.sync has a delay it will throw there. I'll publish the fixes to Chrome Store a bit later. Thanks for the report!

@dahei
Copy link
Author

dahei commented Feb 4, 2016

Thank's for the fix! 👍

@cmmartti
Copy link

cmmartti commented Feb 4, 2016

Yes, thank you. I was just about to create a new issue for this bug.

If I don't wait a few seconds before refreshing the page it gives this exact error. To be sure, I tested it in one of the example pages, which exhibits the same behaviour.

@zalmoxisus
Copy link
Owner

Fixed in v1.0.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants