Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in updated jsan version #540

Closed
minedeljkovic opened this issue Jul 25, 2018 · 4 comments
Closed

regression in updated jsan version #540

minedeljkovic opened this issue Jul 25, 2018 · 4 comments
Labels
bug

Comments

@minedeljkovic
Copy link
Contributor

Parsing during import, which uses custom reviver as well as jsan builtin types, stopped working as of 2.15.3 because of kolodny/jsan#24
@jhen0409 jhen0409 added the bug label Jul 28, 2018
@minedeljkovic
Copy link
Contributor Author

This is fixed in jsan@3.1.11

@zalmoxisus zalmoxisus added this to In progress in 2.16 Nov 17, 2018
@zalmoxisus
Copy link
Owner

Thanks for working on that @minedeljkovic! I published 2.15.4 on Chrome Store now and should be available in an hour. Firefox extension published few days ago already includes this update.

This was referenced Nov 17, 2018
Closed
Closed
@zalmoxisus zalmoxisus removed this from In progress in 2.16 Nov 18, 2018
@zalmoxisus zalmoxisus mentioned this issue Nov 18, 2018
Closed
@zalmoxisus
Copy link
Owner

zalmoxisus commented Nov 25, 2018 •
edited
Loading

Looks like it's not fixed kolodny/jsan#24.

@zalmoxisus zalmoxisus reopened this Nov 25, 2018
zalmoxisus added a commit that referenced this issue Nov 26, 2018
@zalmoxisus
Freeze jsan version to fix reviver issue
3299e2a 
Related to #540 and kolodny/jsan/issues/24
@zalmoxisus
Copy link
Owner

Fixed in kolodny/jsan#26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@minedeljkovic @jhen0409 @zalmoxisus