Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Error on my application with new version v 2.16.0 #588

Closed
vismit opened this issue Nov 28, 2018 · 124 comments
Closed

Getting Error on my application with new version v 2.16.0 #588

vismit opened this issue Nov 28, 2018 · 124 comments

Comments

@vismit
Copy link

vismit commented Nov 28, 2018

Error: You may not call store.getState() while the reducer is executing.

screen shot 2018-11-27 at 5 56 15 pm

@AaronFixer
Copy link

Same issue on my Redux app. Latest dev tools is calling store actions twice and seems the second causes the store.getState() error.

@derekhe
Copy link

derekhe commented Nov 28, 2018

+1 same issue

@wjgogogo
Copy link

same issue

@YingQQQ
Copy link

YingQQQ commented Nov 28, 2018

+1

@SimonTart
Copy link

+1 same issue

1 similar comment
@diegosieg
Copy link

diegosieg commented Nov 28, 2018

+1 same issue

@f4-labs
Copy link

f4-labs commented Nov 28, 2018

+1

@rredureis
Copy link

Same

@mannieschumpert
Copy link

+1

2 similar comments
@nvhoanganh
Copy link

+1

@HarikiRito
Copy link

+1

@udyux
Copy link

udyux commented Nov 28, 2018

+1 It coincided with Chrome updating to version 70.0.3538.110

@tuananhpham142
Copy link

+1

@qxqxqxqx
Copy link

+1 with Chrome 70.0.3538.110

@russellwmy
Copy link

+1

@CharlesMoone
Copy link

+1 with Chrome 70.0.3538.110
save us!
:(

@Goudla
Copy link

Goudla commented Nov 28, 2018

+1

@gordonwoon
Copy link

gordonwoon commented Nov 28, 2018

+1 almost gave up on chrome

@Thraithep
Copy link

+1

3 similar comments
@richieryanmedicaboo
Copy link

+1

@qhapaq
Copy link

qhapaq commented Nov 28, 2018

+1

@Meow-z
Copy link

Meow-z commented Nov 28, 2018

+1

@Diaver
Copy link

Diaver commented Nov 28, 2018

+1!
Spent 3 hours to find exact reason why.

@Xesenix
Copy link

Xesenix commented Nov 28, 2018

obraz
this looks like the source of this error

@ah-kevin
Copy link

+1

1 similar comment
@nhathadt11
Copy link

+1

@nhathadt11
Copy link

nhathadt11 commented Nov 28, 2018

I temporarily get around it by manually loading extension at the version of 2.15.5.

@bpote
Copy link

bpote commented Nov 28, 2018

In case anyone is looking for temporary work around(for chrome), you can download https://github.com/zalmoxisus/redux-devtools-extension/releases/download/2.15.5/extension.zip and then extract it to some folder.

Type chrome://extensions and turn on developer mode from top left and then click on Load Unpacked and select the extracted folder for use.

@CharlesMoone
Copy link

I temporarily get around it by manually loading extension at the version of 2.15.5.

so, that is the ONLY solution for now...
same with you

@CROSSofF
Copy link

After stepping through the isDispatching flag in redux is set at this call of getState()

obraz

so redux is behaving as intended as far as i can tell

@fawazabdulla
Copy link

Totally fine

@trumbitta
Copy link

trumbitta commented Nov 28, 2018

2.16.1 is available on Crome Store. Please let me know if it helps.

@zalmoxisus Not fixed for me with NGRX 6.1.x

@mustkem
Copy link

mustkem commented Nov 28, 2018

thanks it was quick

@michielkikkert
Copy link

2.16.1 is available on Crome Store. Please let me know if it helps.

@zalmoxisus Not fixed for me with NGRX 6.1.x

Nope - not for me either. Running 2.16.1 now.. same whitelist error

@ezintz
Copy link

ezintz commented Nov 28, 2018

It also does not seem to work with @ngrx/store 6.0.1. I also get the whitelist error.

@s-f-a-g
Copy link

s-f-a-g commented Nov 28, 2018

Same for me: ngrx 6.1.2 and 2.16.1 version for extension and it's not working

@vitomanu96
Copy link

+1 same

@zalmoxisus
Copy link
Owner

It works ok with http://ngrx.github.io/example-app/ but maybe that's because it uses nrgx 2.x.
Will publish a new patch now, but would appreciate if someone can share a demo with 3.0 so I can reproduce it.

@lushac
Copy link

lushac commented Nov 28, 2018

Got the same error - tried disabling Redux DevTools however I got another error: "TypeError: Cannot read property 'apply' of undefined". Updating Redux DevTools finally helped to solve those problems -
https://chrome.google.com/webstore/detail/redux-devtools/lmhkpmbekcpmknklioeibfkpmmfibljd

@zalmoxisus
Copy link
Owner

zalmoxisus commented Nov 28, 2018

Shipped 2.16.2 which should fix the issue with ngrx, it should be available on Chrome Store in an hour. Please refer to #589 for that issue.

@pisangGoreng
Copy link

Great, it works now.. Thank you

@michielkikkert
Copy link

Confirmed indeed. 2.16.2 fixes it for me. Thanks @zalmoxisus for the quick resolve and for a truly marvellous extension!

@s-f-a-g
Copy link

s-f-a-g commented Nov 28, 2018

Fixed.
Thanks for the reactivity.
We use it everyday in our dev stack and we forget it. And we also forget it's free.
So a very big thanks for your work !

@codeaid
Copy link

codeaid commented Nov 28, 2018

It's astonishing how many people keep commenting "+1" when they've been asked a million times to not do that and instead use Github's upvote feature that was created specifically to eliminate this problem.

@fqf
Copy link

fqf commented Nov 28, 2018

It's astonishing how many people keep commenting "+1" when they've been asked a million times to not do that and instead use Github's upvote feature that was created specifically to eliminate this problem.

+1 xD

@rubenprodev
Copy link

Not solved for me. I got version 2.16.2

@zalmoxisus
Copy link
Owner

@RubenPRO could you please provide more details about the error you're getting and if possible a repro?

zalmoxisus added a commit that referenced this issue Nov 28, 2018
zalmoxisus added a commit to zalmoxisus/redux-devtools-instrument that referenced this issue Nov 28, 2018
@jamaljeantobias
Copy link

not cool

zalmoxisus added a commit that referenced this issue Nov 28, 2018
@zalmoxisus
Copy link
Owner

2.16.1 was a quick patch removing the part Redux 4 was complaining about. I brought it back and added an workaround passing that state from instrumentation, which would be exactly as getState before, but without Redux noticing and complaining about that. That exception from Redux part in case we're calling getState before reducers are computed makes sense for most of cases, but here we intentionally need that and not looking to application state, but for quantity of actions in lifted state.

Would appreciate if more people could try 2.16.3 before publishing to Chrome Store to avoid breaking client apps. Usually the extension doesn't do anything unless opened and shouldn't cause issues, but here's a sensitive part as we need to count actions before opening the extension.

@EQuimper
Copy link

@zalmoxisus Just finish to test version 2.16.3 all work for me :) Thank you

@zalmoxisus
Copy link
Owner

@fermmm feel free to add more tests for different Redux versions and clients environments.

@zalmoxisus
Copy link
Owner

Published 2.16.3 and it's available now on Chrome Store. If someone still experience any issues, please let me know.

Sorry for the troubles and thanks to everyone who helped here! If you downgraded to 2.15, it's highly recommended to update to the last version as it includes many fixes and improvements in performance. We rarely need to change anything on redux-devtools-instrument part which would affect the client app (without opening extension window). It would be much appreciated, if you can help check the releases for your use case before we ship them to Chrome Store.

@rubenprodev
Copy link

@zalmoxisus sorry i've just read your answer in my previous post. Now, with 2.16.3 it seems it works perfectly. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests