Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] github readme suggests installing package as devDependency #681

Closed
dimadk24 opened this issue Aug 31, 2019 · 1 comment · Fixed by #689
Closed

[Docs] github readme suggests installing package as devDependency #681

dimadk24 opened this issue Aug 31, 2019 · 1 comment · Fixed by #689

Comments

@dimadk24
Copy link
Contributor

From github README:

To make things easier, there's an npm package to install:
npm install --save-dev redux-devtools-extension

User is told to install it as dev dependency. But it definitely should be prod dependency as it's referenced in the code, which launches in production. And npm docs suggest installing as simple dependency:

From npm docs:

npm install --save redux-devtools-extension

@oren-l
Copy link

oren-l commented Sep 19, 2019

I agree, this would fail the build when trying to build with --production flag

zalmoxisus pushed a commit that referenced this issue Oct 4, 2019
Code of package runs in production,
thus we should install it with --save, not with --save-dev

fixes #681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants