Open a devtools panel in Firefox #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox doesn’t have the same requirement for the file:// protocol access, as well as Firefox has yet to implement the necessary chrome.devtools.inspectedWindow.getResources API needed. This change avoids the use of that API in Firefox as it is unnecessary.
|
Your contribution is much appreciated! I'll publish a new version these days. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DevTools panel work has landed in Fx 54 (DevEdition) and seems to be working well for Redux DevTools.
I found one issue, reported in #9 #9 (comment) and this PR fixes that by guarding against the currently unimplemented
devtools.inspectedWindow.getResourcescall which isn't needed for Firefox anyway.