Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace options to TypeScript definition file #624

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Add trace options to TypeScript definition file #624

merged 1 commit into from
Jan 8, 2019

Conversation

denisw
Copy link
Contributor

@denisw denisw commented Jan 7, 2019

The TypeScript definition file was missing trace and traceLimit in the composeWithDevTools() options type, making it a TypeScript error to pass these options. This PR adds them.

@zalmoxisus
Copy link
Owner

Thanks for the contribution! trace option could also be a function returning a string as per API. I guess we could use boolean | Function?

@denisw
Copy link
Contributor Author

denisw commented Jan 8, 2019

Thanks for the contribution! trace option could also be a function returning a string as per API. I guess we could use boolean | Function?

Ah, I missed that! I changed the type of trace to be boolean | (<A extends Action>(action: A) => string).

@zalmoxisus zalmoxisus merged commit 3df4d93 into zalmoxisus:master Jan 8, 2019
@bkaid
Copy link

bkaid commented Feb 1, 2019

Any chance you could cut an NPM release with this change? Tripped me up today. Thanks!

@zalmoxisus
Copy link
Owner

Forgot about it. I published it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants