Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds var trigger for removing odd cols #26

Merged
merged 1 commit into from
Apr 3, 2021
Merged

feat: adds var trigger for removing odd cols #26

merged 1 commit into from
Apr 3, 2021

Conversation

zalog
Copy link
Owner

@zalog zalog commented Mar 28, 2021

  • adds var trigger for removing odd cols, $ph-cols-remove-odd
  • adds $ph-cols var
  • updates README

@zalog
Copy link
Owner Author

zalog commented Mar 28, 2021

Please share your thoughts on this :)

cc:// @MickL @DKhalil

@zalog zalog force-pushed the feature/adds-event-cols-var branch from 0a2cdc3 to 75ca98e Compare March 28, 2021 06:59
@DKhalil
Copy link

DKhalil commented Mar 29, 2021

Looks good to me!

@zalog zalog requested review from nagnibedamihai and removed request for nagnibedamihai March 29, 2021 07:24
@zalog
Copy link
Owner Author

zalog commented Apr 3, 2021

Thanks guys for your feedback and time.
We'll merge this, but please feel free to open a new issue/pr when needed.

@zalog zalog merged commit 5f1e5b1 into develop Apr 3, 2021
@zalog zalog deleted the feature/adds-event-cols-var branch April 3, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zalog @DKhalil