Feature: Generate markdown document from proto file #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 15, 2022 14:19
Add config for caching generated markdown files
whatvn
reviewed
Jun 17, 2022
| @@ -84,7 +87,8 @@ export async function getProtosFromEntitySpec( | |||
| imports: imports.map(pSaveProtoTextAsFile), | |||
| }; | |||
| } catch (err) { | |||
| console.log('OUTPUT ~ getProtosFromEntitySpec ~ err', err); | |||
| logger.info(`Error getProtosFromEntitySpec`); | |||
There was a problem hiding this comment.
Should this 2 lines combine to one with logger.error only, info and error log in 2 lines is confusing
| console.error(`Error generating document. Please submit a new issue at ${REPO_URL}`); | ||
| console.error(`Error:`, err); | ||
| logger.warn(`Error generating document. Please submit a new issue at ${REPO_URL}`); | ||
| logger.error(err); |
| let isGenDoc = req.body.isGenDoc; | ||
|
|
||
| try { | ||
| isGenDoc = JSON.parse(isGenDoc); |
There was a problem hiding this comment.
should this just be JSON.parse(req.body.isGenDoc) ?
There was a problem hiding this comment.
I wrote it for prevent the case req.body.isGenDoc is undefined and JSON.parse will throw error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref zalopay-oss/backstage-grpc-playground#3
protocbinarybackstage-grpc-playground-backend/config.d.ts
Lines 12 to 15 in dceba94
TODO: Cache generated files