fix(cuda): fix multi-GPU implementation when there are few inputs #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slab-ci gpu_test |
|
@slab-ci cpu_test |
6 tasks
|
@slab-ci cpu_test |
IceTDrinker
reviewed
Aug 31, 2022
concrete-core/src/backends/cuda/implementation/engines/cuda_engine/mod.rs
Outdated
Show resolved
Hide resolved
...ckends/cuda/implementation/engines/cuda_engine/lwe_ciphertext_vector_discarding_bootstrap.rs
Outdated
Show resolved
Hide resolved
agnesLeroy
force-pushed
the
fix/multi_gpu
branch
from
918f2e5
to
f8ef830
Compare
|
@slab-ci gpu_test |
|
@slab-ci cpu_test |
agnesLeroy
force-pushed
the
fix/multi_gpu
branch
from
f8ef830
to
c7da817
Compare
|
@slab-ci gpu_test |
IceTDrinker
reviewed
Sep 1, 2022
Comment on lines
+76
to
+81
| let data_per_gpu = input.glwe_dimension().to_glwe_size().0 | ||
| * input.glwe_dimension().to_glwe_size().0 | ||
| * input.input_lwe_dimension().0 | ||
| * input.decomposition_level_count().0 | ||
| * input.polynomial_size().0; | ||
| let size = data_per_gpu as u64 * std::mem::size_of::<u32>() as u64; |
There was a problem hiding this comment.
there already is the need for the compiler in practice https://github.com/zama-ai/concrete-core-internal/issues/188
|
Impressive work refactoring the CUDA backend, @agnesLeroy ! |
IceTDrinker
reviewed
Sep 1, 2022
concrete-core/src/backends/cuda/private/crypto/bootstrap/mod.rs
Outdated
Show resolved
Hide resolved
concrete-core/src/backends/cuda/private/crypto/bootstrap/mod.rs
Outdated
Show resolved
Hide resolved
agnesLeroy
force-pushed
the
fix/multi_gpu
branch
from
c7da817
to
5744513
Compare
|
@slab-ci gpu_test |
agnesLeroy
force-pushed
the
fix/multi_gpu
branch
from
5744513
to
a03f4be
Compare
|
@slab-ci gpu_test |
IceTDrinker
reviewed
Sep 2, 2022
...ore/src/backends/cuda/implementation/engines/cuda_engine/lwe_ciphertext_vector_conversion.rs
Outdated
Show resolved
Hide resolved
concrete-core/src/backends/cuda/private/crypto/bootstrap/mod.rs
Outdated
Show resolved
Hide resolved
IceTDrinker
reviewed
Sep 2, 2022
agnesLeroy
force-pushed
the
fix/multi_gpu
branch
from
a03f4be
to
42315ac
Compare
- also, change some types so that it feels more natural to use them - refactor the whole backend to reduce the probability of bugs
agnesLeroy
force-pushed
the
fix/multi_gpu
branch
from
42315ac
to
dfeaeba
Compare
|
@slab-ci gpu_test |
|
@IceTDrinker normally I took all the comments into account, GPU tests are green! 🙂 |
IceTDrinker
approved these changes
Sep 2, 2022
Maybe, we need to do some benchmarking to check the effect on performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://github.com/zama-ai/concrete-core-internal/issues/382 and https://github.com/zama-ai/concrete-core-internal/issues/389
Description
Checklist
(Use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)