Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler/multi-parameters): Fixing encrypted dot and encrypted matmul with multi-parameters #522

Merged
merged 3 commits into from
Aug 1, 2023
Merged

fix(compiler/multi-parameters): Fixing encrypted dot and encrypted matmul with multi-parameters #522

merged 3 commits into from
Aug 1, 2023

Conversation

rudy-6-4
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jul 24, 2023
@rudy-6-4 rudy-6-4 force-pushed the fix/compiler/addTensorInnerProductEncEnc branch 2 times, most recently from 0e97875 to fa055bb Compare July 24, 2023 15:24
@andrei-stoian-zama
Copy link
Contributor

Does this close #410 ?

andrei-stoian-zama
andrei-stoian-zama reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check that when using signed indeed the lhs correction nodes are created? Doesn't CP apply the TLU trick to make the values unsigned ?

@rudy-6-4 rudy-6-4 force-pushed the fix/compiler/addTensorInnerProductEncEnc branch from c25f9b1 to b3235b3 Compare July 25, 2023 08:10
@rudy-6-4
Copy link
Contributor Author

Does this close #410 ?

No. It only make multi-parameter works, not multi-precision.
error: 'FHE.mul_eint' op should have the width of encrypted inputs and result equal

@rudy-6-4
Copy link
Contributor Author

Can you check that when using signed indeed the lhs correction nodes are created? Doesn't CP apply the TLU trick to make the values unsigned ?

Verified that it appears both in lhs and rhs.

@rudy-6-4 rudy-6-4 force-pushed the fix/compiler/addTensorInnerProductEncEnc branch 7 times, most recently from c157f37 to 9680a2b Compare July 26, 2023 07:51
@BourgerieQuentin
fix(compiler/tests): Fixing some skipped tests laucnhed with gtest pa…
d1ee0a9 
…rallel

The gtest-parallel tools first list test names then launch in parallel the end_to_end_test tool with the gtest_filter=<test_name>,
so if in the test_name a - appears it skip it due the gtest filtering that treat the string after - as an exlude pattern
@BourgerieQuentin BourgerieQuentin force-pushed the fix/compiler/addTensorInnerProductEncEnc branch from 9680a2b to bcc2387 Compare August 1, 2023 13:27
@BourgerieQuentin BourgerieQuentin force-pushed the fix/compiler/addTensorInnerProductEncEnc branch from 9d7a729 to 385dfb3 Compare August 1, 2023 14:46
@BourgerieQuentin BourgerieQuentin force-pushed the fix/compiler/addTensorInnerProductEncEnc branch from 385dfb3 to e60d01e Compare August 1, 2023 14:55
@BourgerieQuentin BourgerieQuentin changed the title fix(compiler): addTensorInnerProductEncEnc aligned on addMul fix(compiler/multi-parameters): Fixing encrypted dot and encrypted matmul with multi-parameters Aug 1, 2023
@BourgerieQuentin BourgerieQuentin merged commit 8e8b2dd into main Aug 1, 2023
23 of 27 checks passed
@BourgerieQuentin BourgerieQuentin deleted the fix/compiler/addTensorInnerProductEncEnc branch August 1, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-stoian-zama andrei-stoian-zama andrei-stoian-zama left review comments

@BourgerieQuentin BourgerieQuentin BourgerieQuentin approved these changes

@aPere3 aPere3 Awaiting requested review from aPere3

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rudy-6-4 @andrei-stoian-zama @BourgerieQuentin