Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(frontend): add a --patch option to ML tests #539

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

bcm-at-zama
Copy link
Contributor

@bcm-at-zama bcm-at-zama commented Aug 8, 2023

to test the removal of workarounds, or the use of new Concrete features

eg, ./ci/scripts/test_cml.sh --last_cp_version --patch patch.diff.txt

with the attached .diff.txt would check if the new VL works fine in ML.

closes #442

--

Remark that it tells you how are the files after modifying:

Installed Concrete-Python: concrete-python==2023.8.8
Applying patch /Users/benoitchevalliermames/Documents/Zama/Git/concrete/patch.diff
Modifications in ML repository:
diff --git a/src/concrete/ml/common/utils.py b/src/concrete/ml/common/utils.py
index 3af1800..5d1b3ee 100644
--- a/src/concrete/ml/common/utils.py
+++ b/src/concrete/ml/common/utils.py
@@ -40,7 +40,7 @@ MAX_BITWIDTH_BACKWARD_COMPATIBLE = 8
 # Use new VL with .simulate() by default once CP's multi-parameter/precision bug is fixed
 # TODO: https://github.com/zama-ai/concrete-ml-internal/issues/3856
 # Indicate if the old simulation method should be used when simulating FHE executions
-USE_OLD_VL = True
+USE_OLD_VL = False

patch.diff.txt

@cla-bot cla-bot bot added the cla-signed label Aug 8, 2023
@bcm-at-zama bcm-at-zama marked this pull request as draft August 8, 2023 09:51
@bcm-at-zama bcm-at-zama marked this pull request as ready for review August 8, 2023 09:56
@bcm-at-zama
Copy link
Contributor Author

Let me see the compliance pro

@bcm-at-zama
Copy link
Contributor Author

Arg, bad merge from Git, I'll fix

to test the removal of workarounds, or the use of new Concrete features

closes #442
@bcm-at-zama bcm-at-zama force-pushed the to_apply_patches_before_ml_tests_442 branch from bdd31c2 to 801b592 Compare August 8, 2023 12:54
@bcm-at-zama
Copy link
Contributor Author

Rebased

@bcm-at-zama
Copy link
Contributor Author

Should I merge it, @BourgerieQuentin ? Or maybe @youben11 wanted to comment on it?

@BourgerieQuentin BourgerieQuentin merged commit 3a884f5 into main Aug 8, 2023
21 checks passed
@BourgerieQuentin BourgerieQuentin deleted the to_apply_patches_before_ml_tests_442 branch August 8, 2023 14:50
@BourgerieQuentin
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants