fix noise in woppbs #592
Merged
fix noise in woppbs #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youben11
force-pushed
the
simu-woppbs-fix
branch
from
9b88dab
to
d1226ca
Compare
rudy-6-4
reviewed
Oct 26, 2023
backends/concrete-cpu/implementation/src/implementation/wop_simulation.rs
Show resolved
Hide resolved
rudy-6-4
approved these changes
Oct 31, 2023
rudy-6-4
force-pushed
the
simu-woppbs-fix
branch
3 times, most recently
from
5d3bee7
to
58d122d
Compare
|
zig test need to be updated |
rudy-6-4
force-pushed
the
simu-woppbs-fix
branch
from
58d122d
to
63e07aa
Compare
rudy-6-4
force-pushed
the
simu-woppbs-fix
branch
from
63e07aa
to
8fbf9f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulation was underestimating the noise after a woppbs.
This should fix the issue.
Still need to do some change on the compiler side (signature of the vertical_packing function has changed)