fix(frontend-python): use more strict inputset to fix a flanky test #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
might help to explain a bit more why you make this change; for future |
|
Explain it where exactly, in the test? 🤔 |
|
Explaining it in the PR. If later, people have a look to understand why you made this change, they'll be happy to have a few info. Just changing something like that, for no obvious reason, without a comment in the src/ or in the PR is not great to me, for future developers. |
|
Edited the PR description 👍 |
BourgerieQuentin
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required because because inputset evaluation happens after fusing and this error was being raised during fusing. So it doesn't have the full bounds or the measured bit-width.