fix(compiler): fix double free on aliased outputs #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcm-at-zama
reviewed
Feb 16, 2024
compilers/concrete-compiler/compiler/tests/end_to_end_tests/end_to_end_jit_test.cc
Outdated
Show resolved
Hide resolved
rudy-6-4
reviewed
Feb 19, 2024
compilers/concrete-compiler/compiler/lib/ServerLib/ServerLib.cpp
Outdated
Show resolved
Hide resolved
rudy-6-4
approved these changes
Feb 19, 2024
aPere3
force-pushed
the
fix/multi_output_double_free
branch
from
37d5707
to
657d39f
Compare
rudy-6-4
approved these changes
Feb 19, 2024
BourgerieQuentin
requested changes
Feb 19, 2024
compilers/concrete-compiler/compiler/tests/end_to_end_tests/end_to_end_jit_test.cc
Outdated
Show resolved
Hide resolved
aPere3
force-pushed
the
fix/multi_output_double_free
branch
from
657d39f
to
8b38585
Compare
|
@slab-ci compiler-macos-tests |
|
Failed to run command: command 'compiler-macos-tests' not found in config file |
BourgerieQuentin
approved these changes
Feb 19, 2024
|
Should we have a Concrete 2.5.2 for that? |
|
If our user doesn't complain I think is not mandatory, we don't want to plublish a new minor for each bug fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.