Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/python multi circuits #724

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Feat/python multi circuits #724

merged 1 commit into from
Mar 19, 2024

Conversation

aPere3
Copy link
Contributor

@aPere3 aPere3 commented Mar 4, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Mar 4, 2024
@aPere3 aPere3 force-pushed the feat/python_multi_circuits branch from 9ac4fd3 to b794caa Compare March 4, 2024 16:27
@aPere3 aPere3 changed the title WIP Feat/python multi circuits Feat/python multi circuits Mar 5, 2024
@aPere3 aPere3 requested a review from umut-sahin March 5, 2024 15:49
@aPere3 aPere3 force-pushed the feat/python_multi_circuits branch from 317a417 to 36a56f6 Compare March 5, 2024 15:51
@aPere3 aPere3 force-pushed the feat/python_multi_circuits branch 3 times, most recently from 6a52047 to 61c4589 Compare March 14, 2024 10:47
BourgerieQuentin
BourgerieQuentin approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's ok to me, but I don't like the namaing especially the fhe.program_circuit, is fhe.function or just fhe.circuit can be a better name? wdyt?

@aPere3 aPere3 force-pushed the feat/python_multi_circuits branch from 61c4589 to 9e23e0c Compare March 14, 2024 13:26
@aPere3
Copy link
Contributor Author

aPere3 commented Mar 14, 2024

Yes, I wanted fhe.circuit but there is already a decorator with that name. I don't like program_circuit either, I left it for discussion. Probably function is the best for now, but that's too bad, it would have been nice the have the same naming throughout the stack.

@aPere3 aPere3 force-pushed the feat/python_multi_circuits branch from 9e23e0c to 372bae1 Compare March 14, 2024 15:01
@aPere3 aPere3 requested a review from rudy-6-4 March 14, 2024 16:09
@aPere3 aPere3 force-pushed the feat/python_multi_circuits branch 3 times, most recently from 967c3f5 to c63123c Compare March 18, 2024 08:22
umut-sahin
umut-sahin requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@umut-sahin umut-sahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done the review for the frontend side. On top of the comments, it's missing a documentation page. It's optional IMO since it's a WIP feature and it can be left undocumented for us to be able to change later. As you wish. CC @BourgerieQuentin

frontends/concrete-python/concrete/fhe/compilation/decorators.py Outdated Show resolved Hide resolved
frontends/concrete-python/tests/compilation/test_program.py Outdated Show resolved Hide resolved
frontends/concrete-python/tests/compilation/test_program.py Show resolved Hide resolved
frontends/concrete-python/tests/compilation/test_program.py Outdated Show resolved Hide resolved
frontends/concrete-python/tests/compilation/test_circuit.py Show resolved Hide resolved
frontends/concrete-python/concrete/fhe/compilation/module.py Outdated Show resolved Hide resolved
frontends/concrete-python/concrete/fhe/compilation/module.py Show resolved Hide resolved
frontends/concrete-python/concrete/fhe/compilation/module.py Show resolved Hide resolved
frontends/concrete-python/concrete/fhe/compilation/module_compiler.py Outdated Show resolved Hide resolved
frontends/concrete-python/concrete/fhe/compilation/module_compiler.py Outdated Show resolved Hide resolved
@aPere3
Copy link
Contributor Author

aPere3 commented Mar 18, 2024

@slab-ci concrete-python-tests-linux

@aPere3 aPere3 force-pushed the feat/python_multi_circuits branch from 5bb37cf to 1869c32 Compare March 19, 2024 13:13
@aPere3 aPere3 merged commit 170002f into main Mar 19, 2024
8 checks passed
@aPere3 aPere3 deleted the feat/python_multi_circuits branch March 19, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudy-6-4 rudy-6-4 rudy-6-4 left review comments

@BourgerieQuentin BourgerieQuentin BourgerieQuentin approved these changes

@umut-sahin umut-sahin umut-sahin approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aPere3 @rudy-6-4 @BourgerieQuentin @umut-sahin