Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): remove p+1 requirement for clear values #752

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

umut-sahin
Copy link
Contributor

No description provided.

@umut-sahin umut-sahin self-assigned this Mar 18, 2024
@cla-bot cla-bot bot added the cla-signed label Mar 18, 2024
Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code of MANP.cpp I think is good and the 2-norm should be correct for smaller integers, but a test on MANP should be added.
Should we also add to this PR the modification of the frontend?

@umut-sahin umut-sahin force-pushed the feat/no-p-plus-one-for-clear-values branch 3 times, most recently from d3d229b to e143bf7 Compare March 19, 2024 12:13
@umut-sahin umut-sahin merged commit 79b72db into main Mar 21, 2024
30 of 32 checks passed
@umut-sahin umut-sahin deleted the feat/no-p-plus-one-for-clear-values branch March 21, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants