-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(frontend): showcase overflow detection #831
Conversation
Updated based on #846 |
374e5e9
to
5cebc60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuxizama can you make a pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
@@ -1,6 +1,6 @@ | |||
# Simulation | |||
|
|||
During development, the speed of homomorphic execution can be a blocker for fast prototyping. You could call the function you're trying to compile directly, of course, but it won't be exactly the same as FHE execution, which has a certain probability of error (see [Exactness](../core-features/table\_lookups.md#table-lookup-exactness)). | |||
During development, the speed of homomorphic execution can be a blocker for fast prototyping. You could call the function you're trying to compile directly, of course, but it won't be exactly the same as FHE execution, which has a certain probability of error (see [Exactness](../core-features/table_lookups.md#table-lookup-exactness)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During development, the speed of homomorphic execution can be a blocker for fast prototyping. You could call the function you're trying to compile directly, of course, but it won't be exactly the same as FHE execution, which has a certain probability of error (see [Exactness](../core-features/table_lookups.md#table-lookup-exactness)). | |
This document explains how to use the simulation feature to speedup prototyping and detect overflows during Fully Homomorphic Encryption (FHE) computation. | |
Simulation allows to mimic the behavior of FHE execution without actually performing the encrypted computations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This original sentence is not very clear to me:
" You could call the function you're trying to compile directly, of course, but it won't be exactly the same as FHE execution, which has a certain probability of error "
- Is this sentence describing the simulation feature? or the issue to be addressed by the simulation feature?
- What does "it" refers to - the simulated function?
- What doesn "which" refers to - the FHE function? of the simulation process?
I would suggest rewriting this part with better clarity.
For example,
Simulations allow to.... (what does it do) It is helpful to .....(why is it useful)
@@ -34,3 +34,24 @@ After the simulation runs, it prints the following: | |||
{% hint style="warning" %} | |||
There are some operations which are not supported in simulation yet. They will result in compilation failures. You can revert to simulation using graph execution using `circuit.graph(...)` instead of `circuit.simulate(...)`, which won't simulate FHE, but it will evaluate the computation graph, which is like simulating the operations without any errors due to FHE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some operations which are not supported in simulation yet. They will result in compilation failures. You can revert to simulation using graph execution using `circuit.graph(...)` instead of `circuit.simulate(...)`, which won't simulate FHE, but it will evaluate the computation graph, which is like simulating the operations without any errors due to FHE. | |
Some operations are not yet supported in simulation and will result in compilation failures. In such cases, you can use graph execution with `circuit.graph(...)` instead of `circuit.simulate(...)`. This will evaluate the computation graph without simulating FHE errors. |
Co-authored-by: yuxizama <157474013+yuxizama@users.noreply.github.com>
f4549f4
to
55e01fd
Compare
No description provided.