Change Partition Operation #858

youben11 · 2024-05-30T08:04:24Z

No description provided.

frontends/concrete-python/concrete/fhe/compilation/compiler.py

rudy-6-4 · 2024-05-30T13:50:13Z

compilers/concrete-compiler/compiler/include/concretelang/Dialect/FHE/IR/FHEOps.td

+
+    let arguments = (ins FHE_AnyEncryptedInteger:$input);
+    let results = (outs FHE_AnyEncryptedInteger);
+    let hasVerifier = 1;


For the partition attribute, can we have strings ? like the name of the partition.
With attribute name like src_partition, dst_partition.
With at least one of the two should be here.

and who's supposed to set those names?

Yes I'm ok with rudy, we need to known which are the source / target partitions else the optimization cannot known which part of the dag should be assigned to an already parametrized partition (the tfhe-rs one in our case). The frontend and/or the user could give this information.

I'm wondering also how we should give the partition(s) parameters, any ideas?

rudy-6-4 · 2024-05-30T13:58:21Z

compilers/concrete-compiler/compiler/lib/Conversion/FHETensorOpsToLinalg/TensorOpsToLinalg.cpp

@@ -2420,6 +2420,24 @@ struct BroadcastToLinalgGeneric
  };
 };

+// This operation should be used by the optimizer in multi-parameters, then
+// removed. Its presence may indicate that mono-parameters might have been
+// used. This patterns just hint for a potential fix.


Removed or replaced by a conversion keyswitch. But isn't it done later during parametrization ? (inserting conversion keyswitch).
Ok it looks like the parametrization transform is named Optimizer.cpp.

Optimizer.Cpp currently removes it without any effect. We can change its behavior once it's really plugged with the optimizer

BourgerieQuentin · 2024-05-31T12:18:11Z

compilers/concrete-compiler/compiler/include/concretelang/Dialect/FHE/IR/FHEOps.td

+
+    let arguments = (ins FHE_AnyEncryptedInteger:$input);
+    let results = (outs FHE_AnyEncryptedInteger);
+    let hasVerifier = 1;


Yes I'm ok with rudy, we need to known which are the source / target partitions else the optimization cannot known which part of the dag should be assigned to an already parametrized partition (the tfhe-rs one in our case). The frontend and/or the user could give this information.

BourgerieQuentin · 2024-05-31T12:24:04Z

compilers/concrete-compiler/compiler/include/concretelang/Dialect/FHE/IR/FHEOps.td

+
+    let arguments = (ins FHE_AnyEncryptedInteger:$input);
+    let results = (outs FHE_AnyEncryptedInteger);
+    let hasVerifier = 1;


I'm wondering also how we should give the partition(s) parameters, any ideas?

BourgerieQuentin · 2024-05-31T12:27:05Z

compilers/concrete-compiler/compiler/lib/Dialect/FHE/Transforms/Optimizer.cpp

@@ -56,6 +56,19 @@ struct OptimizerPartitionFrontierMaterializationPass
    mlir::func::FuncOp func = this->getOperation();

    func.walk([&](mlir::Operation *producer) {
+      mlir::IRRewriter rewriter(producer->getContext());
+
+      // Remove the change_partition op.


I don't understand the TODO? Where is the parameters in the op?

They are currently set in the frontend only, they should be forwarded to the op in a future commit

frontends/concrete-python/concrete/fhe/compilation/compiler.py

umut-sahin

Just a few suggestions on the Python side, looks good 👍

frontends/concrete-python/tests/representation/test_node.py

frontends/concrete-python/tests/dtypes/test_tfhers.py

frontends/concrete-python/concrete/fhe/compilation/module_compiler.py

mypy was complaining hint was a module

we are checking if the selected parameter selection can handle tfhers integers

compilers/concrete-compiler/compiler/include/concretelang/Dialect/FHE/IR/FHEOps.h

BourgerieQuentin · 2024-06-05T11:49:31Z

compilers/concrete-compiler/compiler/include/concretelang/Dialect/FHE/IR/FHEAttrs.td

+    let summary = "An attribute representing a partition.";
+
+    let parameters = (ins
+        "int":$lweDim,


I'm actually not sure that all those attributes should be usefull, especially lweNoiseDistrStdDev, lweNoiseDistrStdDev and msgModulus, carryModulus which are encryption and encoding parameters for radix encoding and at the compiler level we should don't care of that.
But we can keep it like this then prune later.
@rudy-6-4 wdyt?

We need at least the macro parameters that gives the size of the ciphertext and the noise level (either as manp or as a float). Others will not be used by the optimizer since they could be blocking. E.g. even for PBS parameter of this tfhe.rs partition, concrete can have its own parameters (using the same key as tfhers).

BourgerieQuentin · 2024-06-05T11:51:38Z

compilers/concrete-compiler/compiler/include/concretelang/Dialect/FHE/IR/FHEAttrs.td

+        "int":$maxNoiseLevel,
+        "FloatAttr":$log2PFail,
+        "bool": $bigEncryptionKey,
+        DefaultValuedParameter<"int", "-1">: $ciphertextModulus


Is that possible to have verifier on the attr? I guess we should as example not support for ciphertextModulus != 64 at least at the beginning.

I don't think it's possible AFAIK

hasVerifier doesn't seem to be supported at least

BourgerieQuentin · 2024-06-05T11:52:12Z

compilers/concrete-compiler/compiler/include/concretelang/Dialect/FHE/IR/FHEOps.td

+      If necessary, it keyswitch the ciphertext to a different key having a different set of parameters than the original one.
+
+      Example:
+      ```mlir


Can you update the example with src and dst example?

BourgerieQuentin · 2024-06-05T11:54:17Z

compilers/concrete-compiler/compiler/include/concretelang/Dialect/FHE/IR/FHEAttrs.td

+
+    let summary = "An attribute representing a partition.";
+
+    let parameters = (ins


Missing the partition name

frontends/concrete-python/tests/dtypes/test_tfhers.py

youben11 requested review from rudy-6-4, BourgerieQuentin and umut-sahin May 30, 2024 08:04

cla-bot bot added the cla-signed label May 30, 2024

youben11 force-pushed the tfhe-rs-compat-plug-opt branch from 0c87d72 to e651fc9 Compare May 30, 2024 08:32

aPere3 reviewed May 30, 2024

View reviewed changes

frontends/concrete-python/concrete/fhe/compilation/compiler.py Outdated Show resolved Hide resolved

rudy-6-4 reviewed May 30, 2024

View reviewed changes

frontends/concrete-python/concrete/fhe/compilation/compiler.py Outdated Show resolved Hide resolved

rudy-6-4 reviewed May 30, 2024

View reviewed changes

BourgerieQuentin reviewed May 31, 2024

View reviewed changes

umut-sahin reviewed Jun 3, 2024

View reviewed changes

chore(frontend): remove mypy warning about imported func

d0e7b29

mypy was complaining hint was a module

youben11 force-pushed the tfhe-rs-compat-plug-opt branch from 77ce401 to 035bd63 Compare June 4, 2024 08:45

youben11 added 7 commits June 4, 2024 13:24

fix(frontend): support tfhers int with multi-param only

8055c5c

feat(compiler/frontend): change partition operation

140f086

feat(frontend): parametrize tfhers integers

6e33529

feat(compiler): add partition attr to change partition to/from it

27c4502

feat(frontend): forward tfhers params in change_partition op

109294c

docs(compiler): add change_partition/partition_attr to the MLIR docs

4c209e5

refactor(frontend): move tfhers/params check to converter

be92025

we are checking if the selected parameter selection can handle tfhers integers

youben11 force-pushed the tfhe-rs-compat-plug-opt branch from 035bd63 to be92025 Compare June 4, 2024 12:52

BourgerieQuentin requested changes Jun 5, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change Partition Operation #858

Change Partition Operation #858

youben11 commented May 30, 2024

rudy-6-4 May 30, 2024

youben11 May 30, 2024

BourgerieQuentin May 31, 2024

BourgerieQuentin May 31, 2024

rudy-6-4 May 30, 2024 •

edited

Loading

youben11 May 30, 2024

BourgerieQuentin May 31, 2024

BourgerieQuentin May 31, 2024

BourgerieQuentin May 31, 2024

youben11 May 31, 2024

umut-sahin left a comment

BourgerieQuentin Jun 5, 2024

rudy-6-4 Jun 25, 2024

BourgerieQuentin Jun 5, 2024

youben11 Jun 6, 2024

youben11 Jun 6, 2024

BourgerieQuentin Jun 5, 2024

BourgerieQuentin Jun 5, 2024


		let summary = "An attribute representing a partition.";

		let parameters = (ins

Change Partition Operation #858

Are you sure you want to change the base?

Change Partition Operation #858

Conversation

youben11 commented May 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rudy-6-4 May 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

umut-sahin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rudy-6-4 May 30, 2024 •

edited

Loading