feat: updated fhevm version to async decrypt #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immortal-tofu
approved these changes
Mar 27, 2024
immortal-tofu
approved these changes
Apr 5, 2024
leventdem
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is almost surely a bug in oracle service, since the tests in
test/oracleDecryptare passing but the test intest/asyncDecryptis failing, taking forever after the request until reaching the deadline. However, I don't know how to debug the oracle service. @youben11 could you help?If you want to reproduce the bug:
1/
git clonethis PR2/
pnpm i3/ rename
.env.exampleto.env4/
pnpm fhevm:start(wait until logs of the fhevm node show up)5/
pnpm fhevm:faucet, in new terminal6/ (very important, start by this test)
pnpm test test/oracleDecrypt/*-> all tests should pass (same as in fhevm repo)7/
pnpm test test/asyncDecrypt/*-> this should take forever after the request is detected -> Totally unexpected, the bug is here, @youben11 or @immortal-tofu maybe could help on debugging what the hell is happening here8/ now if you try again to run
pnpm test/oracleDecrypt/*again it will fail despite passing the first time in 6/ -> The oracle service seems to have crashed after 7/ ??? how is this working exactly and how to debug it? @youben11 ?