Non zero exit on error #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a remnant of when test and coverage scripts where combined.
Warnings should not result in a non-zero exit status, however.
Current coverage is 86.59% (diff: 100%)@@ master #40 diff @@
==========================================
Files 15 15
Lines 257 261 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 219 226 +7
+ Misses 38 35 -3
Partials 0 0
|
This can probably be expanded significantly, but a decent start. The tests break from other tests in this suite, in that it relies on the fixture's build script for settings. This has the benefit of not needing to update the tests because we change the fixture, but on the other hand we have to add some logic to make sure we link the accurate ez-build version when testing. We also need to ensure we install npm dependencies, but this adds considerable overhead to the execution time of the test, so we only do it in case `node_modules/` doesn't already exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes ensure we exit with a non-zero code whenever the build has non-recoverable errors.
Motivation and Context
Exit codes are used to determine the success or failure of a program, and is often the only reliable way of answering the binary question: did the damn thing work? Before, and this was an oversight, ez-build only exited with a non-zero code when it detected ignored promise rejections – build errors would still result in a zero exit code. With these changes, we ensure that if there are any errors during the build, we exit properly.
How Was This Tested?
Test added in broken-project.bats.
Types of changes
Checklist: