Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix cell editor flakyness
Motivation and Context
The current cell value editor is a bit flaky -- might dispatch
commit
right aftercancel
or might dispatch a couple ofcommit
events when only one was expected.This branch / PR attempts to make it more robust.
How Was This Tested?
A version of the edit cell block has been updated to use a pre-release version with this fix:
http://bl.ocks.org/gabrielmontagne/a6aaeeef596ad1473532318d153f0836
Also, an extra rig which exposes the problems has been added,
examples/edit-cells-lock-on-edit.html
Types of changes
Checklist: