Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP -- Fix esc and double commits #13

Merged
merged 5 commits into from Jan 18, 2017

Conversation

gabrielmontagne
Copy link
Contributor

Description

Fix cell editor flakyness

Motivation and Context

The current cell value editor is a bit flaky -- might dispatch commit right after cancel or might dispatch a couple of commit events when only one was expected.

This branch / PR attempts to make it more robust.

How Was This Tested?

A version of the edit cell block has been updated to use a pre-release version with this fix:
http://bl.ocks.org/gabrielmontagne/a6aaeeef596ad1473532318d153f0836

Also, an extra rig which exposes the problems has been added, examples/edit-cells-lock-on-edit.html

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change follows the style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the contribution guidelines
  • I have added tests to cover my changes
  • All new and existing tests passed

@gabrielmontagne gabrielmontagne merged commit dd783cb into master Jan 18, 2017
@gabrielmontagne gabrielmontagne deleted the fix-esc-and-double-commits branch January 18, 2017 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants