Call to undefined method GuzzleHttp\Exception\ConnectException::getResponse()

[TechPrivacyLab]

In

zammad-api-client-php/src/HTTPClient.php

Line 183 in 83f0129

$response = $e->getResponse();

the getResponse() method is undefined.

To reproduce it I put in the ZammadAPIClient\Client constructor a wrong URL:

use ZammadAPIClient\Client;
$client = new Client([
    'url' => 'https://wrong.zammad.url', // Wrong URL to my Zammad installation
    ...
]);

In this case $e is an instance of GuzzleHttp\Exception\ConnectException with no getResponse() method.

[mgruner]

@TechPrivacyLab could you please check the changes in #51. This is the best I could come up with now, to only wrap the response if one exists, and re-throw the error otherwise.

@jepf do you perhaps remember why the try/catch was done at all? Is it really required?

[jepf]

@jepf do you perhaps remember why the try/catch was done at all? Is it really required?

@mgruner

The try/catch is common practice for error handling at this point.

Possible solutions:
a) try to find the right exception class which contains the response object (maybe there changed something in Guzzle)
b) or just output the message ($e->getMessage())of the exception and return some kind of empty Guzzle request object.

Be sure to not break the behavior by returning something unexpected to the caller.

[mgruner]

@jepf can you check my proposed changes in #51 please? It should not break anything, because it a) returns the error response if one is available and b) does not cause an unrelated RuntimeException as it does right now (that's what this bug is about), but instead throws a proper meaningful exception.