Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass verify option to GuzzleHttp\Client #38

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Conversation

MTEXX
Copy link
Contributor

@MTEXX MTEXX commented Mar 23, 2021

Allow to enable/disable ssl verify in zammad api client.

@thorsteneckel thorsteneckel requested a review from jepf March 23, 2021 15:59
Copy link
Contributor

@jepf jepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MTEXX

Thank you for your pull request.

It seems that guzzle not only supports true and false for its verify option, but that also the path to a CA bundle file can be given: https://docs.guzzlephp.org/en/stable/request-options.html#verify

Would you mind to also add support for this file path?

@MTEXX MTEXX requested a review from jepf March 29, 2021 12:27
@MTEXX
Copy link
Contributor Author

MTEXX commented Mar 29, 2021

@jepf

Did implement the change, please review.

@jepf jepf merged commit 819da52 into zammad:master Mar 29, 2021
@jepf
Copy link
Contributor

jepf commented Mar 29, 2021

@MTEXX

Thank you. Merged and tagged release 2.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants