Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release notes URL construction #99

Closed
zoomoid opened this issue Jun 14, 2021 · 0 comments · Fixed by #100
Closed

Fix release notes URL construction #99

zoomoid opened this issue Jun 14, 2021 · 0 comments · Fixed by #100

Comments

@zoomoid
Copy link
Contributor

zoomoid commented Jun 14, 2021

Is this a request for help?: No

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Version of Helm and Kubernetes: v1.21.1+k3s1

What happened: On deployment using an ingress, the URL constructed in NOTES.txt is wrong due to a schema change from a single string type to a map containing pathType and path values.

What you expected to happen: A fully qualified URL to reach the zammad frontend

How to reproduce it (as minimally and precisely as possible): Enable ingress in values.yaml, add a path and set any pathType. Then deploy the chart and wait for the output.

Anything else we need to know:
@zoomoid zoomoid mentioned this issue Jun 14, 2021
Merged
2 tasks
monotek pushed a commit that referenced this issue Jun 15, 2021
@zoomoid
fix: path construction in NOTES.txt (#99) (#100)
2e7c87f 
* fix: path construction in NOTES.txt (#99)

Signed-off-by: Alexander Bartolomey <occloxium@gmail.com>

* chore: bump chart version to 4.0.1

Signed-off-by: Alexander Bartolomey <occloxium@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: path construction in NOTES.txt (#99)
1 participant
@zoomoid