Skip to content

Commit

Permalink
Improved UX if ticket title is ''.
Browse files Browse the repository at this point in the history
  • Loading branch information
martini committed Sep 11, 2018
1 parent ccbf10c commit dd722f9
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
Expand Up @@ -12,7 +12,7 @@
</td>
<td>
<%- ticket.customer.avatar("50", "", "userInfo-avatar") %>
<h2 style="margin-top: 0px;"><a href="<%- ticket.uiUrl() %>" data-type="edit"><%= ticket.title %></a></h2>
<h2 style="margin-top: 0px;"><a href="<%- ticket.uiUrl() %>" data-type="edit"><%= ticket.title || '-' %></a></h2>
<div class="horizontal">
<div class="vertical flex">
<table style="width: 100%;">
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/app/views/link/info.jst.eco
Expand Up @@ -9,7 +9,7 @@
<%- @Icon('task-state', item.iconClass()) %>
</div>
<div class="task-text">
<a class="name ticket-popover" data-id="<%- item.id %>" href="#ticket/zoom/<%= item.id %>"><%= item.title %></a>
<a class="name ticket-popover" data-id="<%- item.id %>" href="#ticket/zoom/<%= item.id %>"><%= item.title || '-' %></a>
<%- @humanTime(item.created_at) %>
</div>
<div class="list-item-delete js-delete" data-object="Ticket" data-object-id="<%= item.id %>" data-link-type="<%= type %>" data-type="remove">
Expand Down
Expand Up @@ -5,7 +5,7 @@
<%- @Icon('task-state', ticket.iconClass()) %>
</div>
<div class="task-text">
<a class="name" data-id="<%- ticket.id %>" href="<%- ticket.uiUrl() %>">#<%= ticket.number %> <%= ticket.title %></a>
<a class="name" data-id="<%- ticket.id %>" href="<%- ticket.uiUrl() %>">#<%= ticket.number %> <%= ticket.title || '-' %></a>
<%- @humanTime(ticket.created_at, false, 'time') %>
</div>
</li>
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/app/views/ticket_zoom/title.jst.eco
@@ -1 +1 @@
<div contenteditable="true" class="ticket-title-update js-objectTitle" data-placeholder="<%- @Ti('Enter Title...') %>"><%= @object.title %></div>
<div contenteditable="true" class="ticket-title-update js-objectTitle" data-placeholder="<%- @Ti('Enter Title...') %>"><%= @object.title || '-' %></div>
Expand Up @@ -20,7 +20,7 @@
<% for row in @rows: %>
<tr>
<td><a href="#ticket/zoom/<%- row.ticket.id %>"><%= row.ticket.number %></a>
<td title="<%= row.ticket.title %>"><%= row.ticket.title %>
<td title="<%= row.ticket.title %>"><%= row.ticket.title || '-' %>
<td><%= row.customer %>
<td><%= row.organization %>
<td><%= row.agent %>
Expand Down
Expand Up @@ -8,7 +8,7 @@
<%- @Icon('task-state', ticket.iconClass()) %>
</div>
<div class="task-text">
<a class="name ticket-popover" data-id="<%- ticket_id %>" href="<%- ticket.uiUrl() %>"><%= ticket.title %></a>
<a class="name ticket-popover" data-id="<%- ticket_id %>" href="<%- ticket.uiUrl() %>"><%= ticket.title || '-' %></a>
<%- @humanTime(ticket.created_at, false, 'time') %>
</div>
</li>
Expand Down

0 comments on commit dd722f9

Please sign in to comment.