Unavailable ticket template attributes get applied

[thorsteneckel]

Infos:

Used Zammad version: 2.8.x
Installation method (source, package, ..): any
Operating system: any
Database + version: any
Elasticsearch version: any
Browser + version: any

Expected behavior:

• After using a Ticket Template only available attributes are pre-filled

Actual behavior:

• After using a Ticket Template unavailable attributes are pre-filled

Steps to reproduce the behavior:

• Create 2 Agents
• Create 1 Group
• Assign permissions to created Group to Agent 1
• Create Ticket Template with Agent 1 that contains the created Group
• Use created Ticket Template with Agent 2
• See that the (unavailable) Group is selected

Yes I'm sure this is a bug and no feature request or a general question.

Information that help:

The template gets loaded and applied in this area:

zammad/app/assets/javascripts/app/controllers/widget/template.coffee

Lines 79 to 80 in caa5c96

	template = App.Template.find(params['id'])
	App.Event.trigger 'ticket_create_rerender', template.attributes()

This part should be extended to limit/filter the attributes.

The available attributes can be found in the formMeta.dependencies object/hash - which can can get fetched like this:

zammad/app/assets/javascripts/app/controllers/agent_ticket_create.coffee

Lines 47 to 51 in caa5c96

	load = (data) =>
	App.Collection.loadAssets(data.assets)
	@formMeta = data.form_meta
	@buildScreen(params)
	@bindId = App.TicketCreateCollection.one(load)

The logic to filter attributes is currently "trapped" in this file/class. The logic should get extracted to make it reuseable and then used in the "template apply" code.

This affects Ticket#1031263.

[SummerStorm]

Unfortunately the the browser test for this issue cannot be cleanly cherry-picked into stable, so that leaves one customer on stable who is still being affected. We've offered the bump the customer's hosted instance to develop as a temporary measure until the next release.