Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLA fails to set close_in_min and close_diff_in_min #2579

Closed
MrGeneration opened this issue May 21, 2019 · 10 comments
Closed

SLA fails to set close_in_min and close_diff_in_min #2579

MrGeneration opened this issue May 21, 2019 · 10 comments

Comments

@MrGeneration
Copy link
Member

MrGeneration commented May 21, 2019

Infos:

  • Used Zammad version: 2.9
  • Installation method (source, package, ..): any
  • Operating system: any
  • Database + version: any
  • Elasticsearch version: any
  • Browser + version: any
  • Ticket-ID: #1043304, #1062531, #1078017

Expected behavior:

When enabling solution time within a SLA, Zammad will calculate the values close_in_min and close_diff_in_min during closing a ticket.

Actual behavior:

With solution time enabled, Zammad will not set close_in_min and close_diff_in_min values, no matter on how long you wait or in what constellation you set the SLA configuration. This causes close_diff_in_min to be never set.

Further notes:

close_in_min should always be set on closing, especially when using SLA in my opinion. Probably affected line:

self.close_in_min = period_working_minutes(created_at, close_at, biz, history_data)

Steps to reproduce the behavior:

  • Enable SLA with resolving time
  • Create a new ticket that's affected by your SLA filter
  • work a bit on it (notes, call notes)
  • close the ticket ²

² It does not matter if you close the ticket without any note, an internal note or even a mail. The result is always the same.

Yes I'm sure this is a bug and no feature request or a general question.

@SummerStorm SummerStorm changed the title SLA does never set close_in_min and close_diff_in_min SLA fails to set close_in_min and close_diff_in_min Jun 3, 2019
@MrGeneration
Copy link
Member Author

Update: This also affects first response in min :x

@mantas mantas self-assigned this Feb 13, 2020
@thorsteneckel
Copy link
Contributor

thorsteneckel commented Jul 20, 2020

You can also reproduce it this way:

  • Create a SLA that matches all Tickets (e.g. by selecting all Ticket States)
  • Create a new Ticket
  • See that the SLA applies ("escalates in X" in the title region of the Ticket detail view)
  • Close the Ticket

Check the record via the Rails console:

Ticket.last.close_in_min
=> nil

@thorsteneckel thorsteneckel added this to the 3.5.0 milestone Jul 20, 2020
@thorsteneckel thorsteneckel added this to To do in OLD Workflow Jul 28, 2020
@mantas mantas moved this from To do to In progress in OLD Workflow Jul 29, 2020
@mantas mantas moved this from In progress to Stuck in OLD Workflow Jul 29, 2020
@thorsteneckel thorsteneckel modified the milestones: 3.5.0, 3.6.0 Sep 7, 2020
@arpagon
Copy link

arpagon commented Oct 28, 2020

Friendly reminder, this bug is still a thing. I would love to hear more details.

@MrGeneration
Copy link
Member Author

Please have a look at the milestone, it says 3.6~

@thorsteneckel thorsteneckel modified the milestones: 3.6.0, 3.7.0 Nov 6, 2020
@rogedelgado
Copy link

Hello there!

Is there any update on this? We recently move to zammad (great software by the way) and we are trying to get some metrics and as you can imagine, this is affecting us.

Thanks for all the effort in build this amazing tool

@mantas
Copy link
Collaborator

mantas commented Dec 19, 2020

Hi @rogedelgado

We're internally testing a fix for this issue. It'll probably make it to the next release in late January/early February.

@rogedelgado
Copy link

rogedelgado commented Dec 21, 2020

Hi @mantas, good news indeed!

We look forward for the new release!

@thorsteneckel thorsteneckel moved this from Stuck to Review in OLD Workflow Feb 12, 2021
@thorsteneckel thorsteneckel moved this from Review to Done in OLD Workflow Feb 15, 2021
@GaiaRossi
Copy link

Hello there!

Are there any updates?

Thanks! :-)

@crnfpp
Copy link
Contributor

crnfpp commented Mar 3, 2023

Hi! Having the same issues with the most recent Zammad version.

@MrGeneration
Copy link
Member Author

Please don't hijack old issues. Open new issues if you're sure that it is a bug and not a technical question.

@zammad zammad locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
OLD Workflow
  
Done
Development

No branches or pull requests

7 participants