Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile out of office toasters untranslatable #2666

Closed
maxxer opened this issue Jul 15, 2019 · 6 comments
Closed

Profile out of office toasters untranslatable #2666

maxxer opened this issue Jul 15, 2019 · 6 comments

Comments

@maxxer
Copy link
Contributor

maxxer commented Jul 15, 2019

Zammad 3.0.x

When setting out of office in user profile toaster messages may appear, like user is required (or something like that) and Successfully!. Both those messages aren't listed in the translations page

@MrGeneration
Copy link
Member

This can be found here:

msg: App.i18n.translateContent('Successfully!')

I think we should change this from Successfully! to Successfully!, because I think it's nearly the same (at least in german the same result will be translated ;) ).

What do you think, @dennybresch ? :)

@maxxer
Copy link
Contributor Author

maxxer commented Jul 15, 2019

The word itself is not really meaningful... Something like Settings stored would be slightly better, isn't it?

@dennykorsukewitz dennykorsukewitz self-assigned this Jul 22, 2019
@dennykorsukewitz
Copy link
Contributor

Hi @maxxer @MrGeneration ,

Successfully!and Successful! are already present on the i18n.
First of all we should check why they are not displayed in the translation overview.

If we change this notice, we should use a general wording so that it can be used more often in user preferences and admin area AND to keep the number of translations small.

Update successful! already exists and could be used directly.

@MrGeneration
Copy link
Member

I'd like to vote for Update successful and Settings stored successful :-P

@maxxer
Copy link
Contributor Author

maxxer commented Sep 3, 2019

Update successful is fine to me. Settings stored successful should be lly :)

@MrGeneration MrGeneration removed their assignment Jun 11, 2020
@mgruner mgruner added this to the 5.1 milestone Sep 8, 2021
@mgruner
Copy link
Collaborator

mgruner commented Sep 8, 2021

This will be fixed with the upcoming migration to Weblate in Zammad 5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants