Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Third-Party login: Office 365 to Microsoft 365 #3245

Closed
MrGeneration opened this issue Oct 8, 2020 · 3 comments
Closed

Rename Third-Party login: Office 365 to Microsoft 365 #3245

MrGeneration opened this issue Oct 8, 2020 · 3 comments

Comments

@MrGeneration
Copy link
Member

Infos:

  • Used Zammad version: 3.5
  • Installation method (source, package, ..): any
  • Operating system: any
  • Database + version: any
  • Elasticsearch version: any
  • Browser + version: any

Desired behavior:

Office 365 is no longer an available product by Microsoft.
Instead the login option should rather be called Microsoft or -if we must- Microsoft 365.

Personally, as the login functionality works for both Office products and personal microsoft accounts without any office 365 products, I'd prefer Microsoft.

This technically might be blocked by our omniauth gem.

Actual behavior:

Currently the login button and login setting is called Office 365.

image

@MrGeneration MrGeneration added this to the 3.6.0 milestone Oct 26, 2020
@MrGeneration MrGeneration added this to To do in OLD Workflow Oct 26, 2020
@MrGeneration MrGeneration removed this from the 3.6.0 milestone Oct 26, 2020
@SupersonicWaffle
Copy link

SupersonicWaffle commented Nov 19, 2020

I believe this is not entirely correct.
Microsoft 365 has been a product that has been available for a few years. Office 365 Enterprise plans are still available and distinct from Microsoft 365 Enterprise.
Office 365 Business plans however have been merged with Microsoft 365 Business plans.

If consistency is desired something along the lines of Azure AD Authentication might make more sense.

@MrGeneration
Copy link
Member Author

MrGeneration commented Nov 19, 2020

While this is correct, this channel is not entirely about the Online Exchange services, but also covers outlook.com private accounts.

Edit:
We could also make it more general "Microsoft" which would be correct too.

@SupersonicWaffle
Copy link

Right, I guess I missed that between doing too many things at once.
I would agree that generically calling it "Microsoft" would make most sense.

Cheers

@mantas mantas self-assigned this Jul 5, 2021
@mantas mantas moved this from To do to Review in OLD Workflow Oct 28, 2021
@rolfschmidt rolfschmidt removed this from Review in OLD Workflow Dec 7, 2021
@mantas mantas added this to the 5.1 milestone Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants