Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup of Zammad does not synchronize the custom branding logo #3933

Closed
MrGeneration opened this issue Jan 24, 2022 · 2 comments
Closed

Startup of Zammad does not synchronize the custom branding logo #3933

MrGeneration opened this issue Jan 24, 2022 · 2 comments
Assignees
Milestone

Comments

@MrGeneration
Copy link
Member

Infos:

  • Used Zammad version: any (at least with Zammad 4.0 and higher)
  • Installation method (source, package, ..): any
  • Operating system: any
  • Database + version: any
  • Elasticsearch version: any
  • Browser + version: any

Expected behavior:

Zammad synchronizes the current branding logo from database to to file system upon startup.

Actual behavior:

Synchronizing branding logos from database to file system does not happen during start up.
This potentially causes issues upon specific restoration processes.

Steps to reproduce the behavior:

  • Upload a custom logo (via branding) and submit
  • Stop Zammad
  • Remove the custom logo from file system (find all of them:
    find /opt/zammad/public/assets/images/ -type f -regextype sed -regex ".*/[0-9a-f]\{32\}\.png")
  • Start Zammad
  • check public/assets/images/ listings

Yes I'm sure this is a bug and no feature request or a general question.

@martini
Copy link
Collaborator

martini commented Jan 24, 2022

The problem is this line. If I comment this out everything is working nice.

https://github.com/zammad/zammad/blob/develop/config/initializers/logo.rb#L5

Got introduced with 5745fa4#diff-b4a195f23c3174ac126a32ea1daba32f7b246899846171aea397de5f6c95e054R1

@martini
Copy link
Collaborator

martini commented Jan 25, 2022

As site note, the origin of the issue is coming from changed rake behavior in Rails 5.2, see rails/rails#32870

@dominikklein dominikklein added this to the 5.1 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants