fix cookie parsing

zamronypj · Aug 10, 2019 · 7b766b1 · 7b766b1
1 parent c7bed91
commit 7b766b1
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/Http/Request/RequestImpl.pas b/src/Http/Request/RequestImpl.pas
@@ -34,7 +34,9 @@ interface
     (*!------------------------------------------------
      * basic class having capability as
      * HTTP request
-     *
+     *-------------------------------------------------
+     * TODO: refactor
+     *-------------------------------------------------
      * @author Zamrony P. Juhara <zamronypj@yahoo.com>
      *-----------------------------------------------*)
     TRequest = class(TInterfacedObject, IRequest)
@@ -64,7 +66,8 @@     TRequest = class(TInterfacedObject, IRequest)
 
         procedure initParamsFromString(
             const data : string;
-            const body : IList
+            const body : IList;
+            const separatorChar : char = '&'
         );
 
         procedure initPostBodyParamsFromStdInput(
@@ -272,13 +275,14 @@ implementation
 
     procedure TRequest.initParamsFromString(
         const data : string;
-        const body : IList
+        const body : IList;
+        const separatorChar : char = '&'
     );
     var arrOfQryStr, keyvalue : TStringArray;
         i, len, lenKeyValue : integer;
         param : PKeyValue;
     begin
-        arrOfQryStr := data.split(['&']);
+        arrOfQryStr := data.split([separatorChar]);
         len := length(arrOfQryStr);
         for i:= 0 to len-1 do
         begin
@@ -307,7 +311,7 @@ implementation
         const cookies : IList
     );
     begin
-        initParamsFromString(env.httpCookie(), cookies);
+        initParamsFromString(env.httpCookie(), cookies, ';');
     end;
 
     procedure TRequest.raiseExceptionIfPostDataTooBig(const contentLength : int64);