[Bug] Fixed Redirect URI corruption (#142)

list(redirect_uri) was splitting the redirect_uri string into pieces.
zamzterz · Feb 5, 2023 · 9929265 · 9929265
1 parent 41a0ae8
commit 9929265
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/flask_pyoidc/pyoidc_facade.py b/src/flask_pyoidc/pyoidc_facade.py
@@ -44,7 +44,7 @@ def __init__(self, provider_configuration, redirect_uri):
 
         if self._provider_configuration.registered_client_metadata:
             client_metadata = self._provider_configuration.registered_client_metadata.to_dict()
-            client_metadata.update(redirect_uris=list(redirect_uri))
+            client_metadata.update(redirect_uris=[redirect_uri])
             self._store_registration_info(client_metadata)
 
         self._redirect_uri = redirect_uri

diff --git a/tests/test_pyoidc_facade.py b/tests/test_pyoidc_facade.py
@@ -25,7 +25,14 @@ class TestPyoidcFacade:
     def test_registered_client_metadata_is_forwarded_to_pyoidc(self):
         config = ProviderConfiguration(provider_metadata=self.PROVIDER_METADATA, client_metadata=self.CLIENT_METADATA)
         facade = PyoidcFacade(config, REDIRECT_URI)
-        assert facade._client.registration_response
+
+        expected = {
+            'client_id': self.CLIENT_METADATA['client_id'],
+            'client_secret': self.CLIENT_METADATA['client_secret'],
+            'redirect_uris': [REDIRECT_URI],
+            'token_endpoint_auth_method': 'client_secret_basic'
+        }
+        assert facade._client.registration_response.to_dict() == expected
 
     def test_no_registered_client_metadata_is_handled(self):
         config = ProviderConfiguration(provider_metadata=self.PROVIDER_METADATA,